Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] fix multiple issues for Organisation Admins (#8101) #8459

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[backend/frontend] fix multiple issues for Organisation Admins (#8101) #8459

merged 1 commit into from
Oct 18, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Sep 23, 2024 •
edited
Loading

Proposed changes

  • 2 create (relations)
  • 4 updates (Identity)
  • 2 delete

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.28%. Comparing base (f65806d) to head (deb3ad3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pencti-platform/opencti-graphql/src/domain/user.js 16.66% 10 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8459   +/-   ##
=======================================
  Coverage   66.27%   66.28%           
=======================================
  Files         597      597           
  Lines       60916    60929   +13     
  Branches     6249     6255    +6     
=======================================
+ Hits        40375    40387   +12     
- Misses      20541    20542    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact marked this pull request as ready for review October 14, 2024 08:38
@lndrtrbn lndrtrbn self-assigned this Oct 14, 2024
lndrtrbn
lndrtrbn reviewed Oct 14, 2024
View reviewed changes
opencti-platform/opencti-graphql/src/domain/user.js Outdated Show resolved Hide resolved
opencti-platform/opencti-graphql/src/python/testing/local_synchronizer.py
Comment on lines +65 to +67
type = data["data"]["type"]
if type == "internal-relationship":
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this? We want to do nothing if internal relationship ? If I understand correctly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... this is to avoid to count "internal-relationiship" in raw stream . am I right @SouadHadjiat ?

Copy link
Member

@SouadHadjiat SouadHadjiat Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we don't want to synchronize internal relationships : we actually never create them anyway, the issue we had is that we couldn't delete them because they weren't created.

Copy link
Member

@SouadHadjiat SouadHadjiat Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we however need them in the stream, because we have an inferrence rule for participates-to relationships (user member of an organization, we infere the relationship with parent organizations)

Copy link
Member

@lndrtrbn lndrtrbn Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok thanks, could you explain to me what is the role of the local synchronizer? I think it could help me understand what we do in process_message

For what I understand: we do not need to synchronize internal rels as there is nothing to sync because they are not created

@marieflorescontact marieflorescontact merged commit b04b787 into master Oct 18, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/8101 branch October 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat left review comments

@lndrtrbn lndrtrbn lndrtrbn approved these changes

Assignees

@lndrtrbn lndrtrbn

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marieflorescontact @SouadHadjiat @lndrtrbn